Fokko commented on code in PR #6139:
URL: https://github.com/apache/iceberg/pull/6139#discussion_r1023280537
##########
python/pyiceberg/expressions/__init__.py:
##########
@@ -48,12 +65,13 @@ class Bound(ABC):
"""Represents a bound value expression"""
-class Unbound(Generic[B], ABC):
+class Unbound(ABC):
"""Represents an unbound value expression"""
+ @property
@abstractmethod
- def bind(self, schema: Schema, case_sensitive: bool = True) -> B:
- ... # pragma: no cover
+ def as_bound(self) -> Type[Bound]:
+ ...
class BoundTerm(Term[T], Bound, ABC):
Review Comment:
I've fixed those, what we're left with now is:
```
python/tests/expressions/test_visitors.py:334: error: Cannot infer type
argument 1 of "BoundIn"
python/tests/expressions/test_visitors.py:341: error: Cannot infer type
argument 1 of "BoundIn"
python/tests/expressions/test_visitors.py:364: error: Cannot infer type
argument 1 of "BoundIn"
python/tests/expressions/test_visitors.py:371: error: Cannot infer type
argument 1 of "BoundEqualTo"
python/tests/expressions/test_visitors.py:379: error: Cannot infer type
argument 1 of "BoundEqualTo"
python/tests/expressions/test_visitors.py:405: error: Cannot infer type
argument 1 of "BoundIn"
python/tests/expressions/test_visitors.py:412: error: Cannot infer type
argument 1 of "BoundIn"
python/tests/expressions/test_visitors.py:435: error: Cannot infer type
argument 1 of "BoundIn"
python/tests/expressions/test_visitors.py:442: error: Cannot infer type
argument 1 of "BoundIn"
python/tests/expressions/test_visitors.py:450: error: Cannot infer type
argument 1 of "BoundIn"
python/tests/expressions/test_visitors.py:493: error: Cannot infer type
argument 1 of "BoundIn"
python/tests/expressions/test_visitors.py:503: error: Cannot infer type
argument 1 of "BoundIn"
python/tests/expressions/test_visitors.py:516: error: Cannot infer type
argument 1 of "BoundEqualTo"
python/tests/expressions/test_visitors.py:538: error: Cannot infer type
argument 1 of "BoundIn"
python/tests/expressions/test_visitors.py:556: error: Cannot infer type
argument 1 of "BoundIn"
python/tests/expressions/test_visitors.py:563: error: Cannot infer type
argument 1 of "BoundIn"
python/tests/expressions/test_expressions.py:223: error: Cannot infer type
argument 1 of "BoundNotEqualTo"
python/tests/expressions/test_expressions.py:271: error: Cannot infer type
argument 1 of "BoundNotIn"
python/tests/expressions/test_expressions.py:282: error: Cannot infer type
argument 1 of "BoundIn"
python/tests/expressions/test_expressions.py:307: error: Cannot infer type
argument 1 of "BoundNotEqualTo"
python/tests/expressions/test_expressions.py:320: error: Cannot infer type
argument 1 of "BoundEqualTo"
python/tests/expressions/test_expressions.py:333: error: Cannot infer type
argument 1 of "BoundLessThan"
python/tests/expressions/test_expressions.py:346: error: Cannot infer type
argument 1 of "BoundLessThanOrEqual"
python/tests/expressions/test_expressions.py:359: error: Cannot infer type
argument 1 of "BoundGreaterThanOrEqual"
python/tests/expressions/test_expressions.py:372: error: Cannot infer type
argument 1 of "BoundGreaterThan"
```
Seems like it is unable to determine the type of the `BoundTerm`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
