Fokko commented on code in PR #6139:
URL: https://github.com/apache/iceberg/pull/6139#discussion_r1022396132
##########
python/tests/expressions/test_expressions.py:
##########
@@ -365,7 +344,7 @@ def
test_bound_greater_than_or_equal_invert(table_schema_simple: Schema):
def test_bound_greater_than_invert(table_schema_simple: Schema):
- bound = BoundGreaterThan(
+ bound = BoundGreaterThan[str](
Review Comment:
I gave it a try yesterday, and it became very messy. Also, even with the
`typing_extensions`, we can't do unpacking of the type in Python <3.11:
```python
Ts = TypeVarTuple("Ts")
class StructType(Generic[*Ts]): # The *Ts is not supported, even with
typing_extensions
fields: NestedFields[*Ts]
```
I think we should leave this for now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
