Fokko commented on code in PR #6139:
URL: https://github.com/apache/iceberg/pull/6139#discussion_r1022009454
##########
python/pyiceberg/expressions/__init__.py:
##########
@@ -126,10 +164,13 @@ def bind(self, schema: Schema, case_sensitive: bool =
True) -> BoundReference[T]
"""
field = schema.find_field(name_or_id=self.name,
case_sensitive=case_sensitive)
accessor = schema.accessor_for_field(field.field_id)
- return BoundReference(field=field, accessor=accessor)
+ return self.as_bound(field=field, accessor=accessor)
+
+ @property
+ def as_bound(self) -> Type[BoundReference]:
Review Comment:
For the projection transforms we need to have it the other way around
`as_unbound`:
https://github.com/apache/iceberg/pull/6128/files#diff-6e61823ae852914cf80ce42354961efd01d99b58fa7804d931ba9cf7ba8edac8R312-R315
We can't do it the same way because it creates a circular reference. I think
it is nice to have it the same way.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
