tanmayrauth commented on PR #2347: URL: https://github.com/apache/iceberg-go/pull/2347#issuecomment-6581519243
Thanks @laskoviymishka! I took a look and only part of it fits. iceberg-verification wants expected values from the spec, and the Puffin spec only pins a compact Alpha sketch with the default seed and single-value serialization. Most of what these tests check comes from DataSketches-Java defaults that we have to match for union compatibility: lgK=12, the 4096 union trim, skipping empty values. iceberg-go also doesn't consume that repo yet. OK to land this as is? I'll follow up with a Puffin theta surface PR over there, and switch the spec-level checks once we have a way to pin it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
