tanmayrauth commented on PR #2347:
URL: https://github.com/apache/iceberg-go/pull/2347#issuecomment-6479214749
Thanks @zeroshade for the thorough review, all addressed:
1. Added the license header to the testdata README.
2. Add now skips empty values, matching Java's update(ByteBuffer), with
tests.
3. Replaced the fixtures with ones generated by dev/theta-fixtures, which
replays ThetaSketchAgg with datasketches-java 6.2.0 (Alpha per partition, union
merge, Conversions.toByteBuffer per type, empty values, serVer 3). The tests
compare decoded state. Exact up to 4096 distinct values per partition; past
that, compared within error bounds.
4. Dropped the Spark claim; the integration test will land with the
stats-file writer PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
