hzmsh commented on PR #4108: URL: https://github.com/apache/iceberg-python/pull/4108#issuecomment-6475907051
Hi @Fokko, a gentle ping on this one. Filtering a `float` column by a value like `0.1` can miss rows today; this PR rounds the literal to float32, as the spec and Java do. It's rebased on the latest `main`, and all checks pass except `cibw-dev-env-smoke-test`, which was cancelled while building the wheel ([log](https://github.com/apache/iceberg-python/actions/runs/40728773162/job/122959082170)). Could you re-run it and take a look when you have a moment? Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
