yyanyy commented on code in PR #18416: URL: https://github.com/apache/iceberg/pull/18416#discussion_r4277846013
########## format/spec.md: ########## @@ -1562,6 +1571,7 @@ Lists must use the [3-level representation](https://github.com/apache/parquet-fo | **`binary`** | `binary` | | | | **`struct`** | `group` | | | | **`list`** | `3-level list` | `LIST` | See Parquet docs for 3-level representation. | +| **`vector(E, D)`** | `3-level list` | `VECTOR(D)` | The element must be required and use the Parquet mapping for E. See [apache/parquet-format#624](https://github.com/apache/parquet-format/pull/624). | Review Comment: thanks, this was originally a placeholder to track the parquet proposal as I was still thinking how we should handle the timing of this PR and the parquet spec PR. I’ve updated the mapping to use the existing LIST annotation, assuming the Parquet PR has not merged. The notes now spell out the physical layout and vector constraints directly. Once Parquet finalizes VECTOR, we can update the logical type annotation to the finalized VECTOR definition. I’ll also raise this at the next sync to confirm whether we should proceed with this mapping while the Parquet proposal remains open. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
