yyanyy commented on code in PR #18416: URL: https://github.com/apache/iceberg/pull/18416#discussion_r4265980947
########## format/spec.md: ########## @@ -295,6 +297,12 @@ For details on how to serialize a schema to JSON, see Appendix C. [1001]: <https://portal.ogc.org/files/?artifact_id=25355> "OGC Simple feature access" +##### Vector + +Every non-null `vector(E, D)` value must contain exactly D non-null elements of type E. Floating-point elements must not be `NaN`, positive infinity, or negative infinity. The vector value itself may be null when the containing field is optional. + +No type promotion to or from `vector` is defined, including changes to its element type or dimension. Lower and upper bounds are not defined for vector values. Review Comment: thanks everyone, > No sort order is defined for a vector value From some offline conversation there was a feedback that we might not need to artificially remove the sort order requirement, since vectors can in deed be sort naturally. While I don't have a concrete use case now, I'm thinking to not mention that this is not permitted to introduce unnecessary complication? > stats I'll need to update this PR one more time to reflect the consensus from the sync meeting that we don't plan to support stats for vector, though I need to think about where is the best place for it to be mentioned > identify int8/uint8 etc I think the tentative agreement from the sync meeting is that the underlying type should be treated as opaque since most likely only engine would care the most? I do need to do some extra research on how we handle parquet when the underlying physical type is slightly different. But I think even if we want to give this info somewhere, having it in stats probably is a too indirect way of doing that? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
