yyanyy commented on code in PR #18416:
URL: https://github.com/apache/iceberg/pull/18416#discussion_r4276093296
##########
format/spec.md:
##########
@@ -1888,6 +1901,7 @@ The binary single-value serialization can be used to
store the lower and upper b
| **`binary`** | **`JSON string`** |
`"000102ff"` | Stored as a hexadecimal string |
| **`struct`** | **`JSON object by field ID`** | `{"1": 1,
"2": "bar"}` | Stores struct fields using the field ID as
the JSON field name; field values are stored using this JSON single-value
format |
| **`list`** | **`JSON array of values`** | `[1, 2, 3]`
| Stores a JSON array of values that are
serialized using this JSON single-value format |
+| **`vector(E, D)`** | **`JSON array of values`** | `[1.0, 2.0,
3.0]` | Stores exactly D values using E's JSON
single-value format |
Review Comment:
good call on not allowing non-null default, updated the spec for it (and put
an item in next sync meeting in case people have extra thoughts). Though I'll
probably not remove the `[1.0, 2.0, 3.0]` representation here, since this is
just about json serialization demonstration, which might go beyond the default
values' use case (e.g. for defining an expression per expression spec)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
