C-Loftus commented on code in PR #2125:
URL: https://github.com/apache/iceberg-go/pull/2125#discussion_r4214040982
##########
table/internal/parquet_files.go:
##########
@@ -1207,6 +1210,7 @@ func (w *ParquetFileWriter) accumulateGeoBounds(batch
arrow.RecordBatch) error {
if !ok {
continue
}
+ w.geoNullCounts[gc.fieldID] += int64(storage.NullN())
Review Comment:
I'm scoping this out on purpose for now since it is a bit more significant
of a change: `TestWriteDataFileNestedGeoNullCount` pins the current behavior
(value count recorded, no null count for the nested geo field), and the note
next to TODO on collectGeoColumns also covers the AddFiles path.
If that isn't the right fit let me know and happy to revisit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
