C-Loftus opened a new pull request, #2125:
URL: https://github.com/apache/iceberg-go/pull/2125

   ## Bump geoarrow-go to fc2b33c
   
   Closes https://github.com/apache/iceberg-go/issues/1569
   Should be the last part of https://github.com/apache/iceberg-go/issues/989 
for core geo support
   
   Updates `github.com/geoarrow/geoarrow-go` to 
[`fc2b33c`](https://github.com/geoarrow/geoarrow-go/commit/fc2b33c3141d6e39b55d0cff22fea9252d571fde).
 With this version, WKB columns are written with the Parquet `GEOMETRY` / 
`GEOGRAPHY` logical types instead of no logical type.
   
   ### Changes
   - **Dependency:** bump geoarrow-go in `go.mod` / `go.sum`. No other 
dependency changes.
   - **Geo null counts** (`table/internal/parquet_files.go`): Parquet geo 
logical types have an undefined sort order, so the Parquet writer leaves out 
column statistics for them. Without those statistics, `DataFileStatsFromMeta` 
can no longer recover null counts. The writer now counts nullArrow data while 
writing and adds them to thefile statistics.
     - `counts` mode now records the null count but no bounds. Before, it 
recorded neither.
     - `none` mode still records nothing.
   - **Tests:**
     - `TestGeoTypeParquetRoundTrip` now checks the expected Parquet logical 
type and CRS for each case. Per the Parquet spec, CRS is written as 
`srid:<id>`, and the default `OGC:CRS84` is omitted.
     - `TestWriteDataFileGeoBounds` checks geo nuls mode.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to