mixermt commented on code in PR #3111:
URL: https://github.com/apache/iceberg-rust/pull/3111#discussion_r4194185008
##########
.github/workflows/ci.yml:
##########
@@ -241,6 +241,9 @@ jobs:
- name: Start Docker containers
if: matrix.test-suite.name == 'default'
+ env:
+ # The HDFS fixture needs host networking; opt in here (Linux only).
+ COMPOSE_PROFILES: hdfs
Review Comment:
Measured on CI: the profile added ~40 s to "Start Docker containers" (108 s
→ 147 s) on every default run, and with `--wait` a fixture hiccup fails the
suite before any test runs. Moved it to a dedicated `Tests (hdfs)` job that
starts only the two HDFS containers and runs the HDFS test binary; the default
job no longer pulls the image, and the HDFS tests self-skip there. I kept the
new job in `ci-required` so the backend's tests stay gating, but a flake now
costs a one-job re-run rather than the whole suite. One known limitation of the
self-skip pattern (shared with the HF tests): the job only tests anything
because it sets the endpoint variable, so that line is load-bearing. `--wait`
and the profile were already in place. Lands with the next push.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
