mixermt commented on code in PR #3111:
URL: https://github.com/apache/iceberg-rust/pull/3111#discussion_r4194082722
##########
crates/storage/opendal/src/lib.rs:
##########
@@ -243,6 +261,18 @@ pub enum OpenDalStorage {
/// GCS configuration.
config: Arc<GcsConfig>,
},
+ /// HDFS storage variant.
+ ///
+ /// The NameNode is taken from the `hdfs.name-node` property when set
+ /// (comma-separated endpoints enable HA failover), else the path
authority.
+ #[cfg(feature = "opendal-hdfs-native")]
+ HdfsNative {
+ /// HDFS configuration.
+ config: Arc<HdfsNativeConfig>,
+ /// Operator cache keyed by effective NameNode.
+ #[serde(skip, default)]
+ operators: HdfsNativeOperatorCache,
Review Comment:
Done: the variant is now `HdfsNative(HdfsNativeStorage)`, one public struct
with crate-private fields and no public constructor, so only the factories
build it and the cache type is no longer public (`HdfsNativeOperatorCache` is
`pub(crate)`). The `#[non_exhaustive]` plus `pub(crate)` field route does not
compile (E0446, the field type would be more private than the variant). The
serialized form keeps the same nesting, which the new round-trip test pins, and
`HdfsNative` now takes part in `test_factory_propagates_io_timeout`, which had
listed every factory but this one. Lands with the next push.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
