mixermt commented on code in PR #3111: URL: https://github.com/apache/iceberg-rust/pull/3111#discussion_r4174483348
########## crates/iceberg/src/io/storage/config/hdfs.rs: ########## @@ -0,0 +1,27 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +//! HDFS storage configuration. + +/// HDFS NameNode RPC endpoint(s), e.g. `hdfs://namenode:8020`; a +/// comma-separated list enables HA failover. When unset, the NameNode is +/// derived from the path authority. +pub const HDFS_NAME_NODE: &str = "hdfs.name-node"; Review Comment: Good point, and the crate's convention is to use PyIceberg's keys, so I added `hdfs.host`/`hdfs.port` (port defaults to 8020 like pyarrow). I kept PyIceberg's semantics for them: they apply only to authority-less paths, since PyIceberg itself uses the URI's netloc first and only reads these props when there is none. Internally they map to Hadoop's `fs.defaultFS`, so `hadoop.fs.defaultFS` works the same way. `hdfs.name-node` remains the explicit override, which HA logical names need with hdfs-native. `hdfs.user`/`hdfs.kerberos_ticket` have no equivalent in opendal's config; hdfs-native reads `HADOOP_USER_NAME` and the default Kerberos cache, which the `HDFS_HOST` doc now states. Lands with the next push. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
