sungwy commented on code in PR #3:
URL:
https://github.com/apache/iceberg-verification/pull/3#discussion_r4086942448
##########
table-spec/schema/core/cases.json:
##########
@@ -0,0 +1,693 @@
+{
+ "cases": [
+ {
+ "id": "flat-required-and-optional",
+ "valid": true,
+ "input": {
+ "type": "struct",
+ "schema-id": 0,
Review Comment:
The spec doesn't fix a default in the optional case.
Appendix C makes schema-id optional in v1 and required in v2, and the 0 is
only in the Example column. Java and PyIceberg both fall back to 0, but that's
an implementation choice.
If we want to add that case, I think we'd want to clarify the spec first,
but I also don't want to waste the community's time in clarifying a V1 spec.
I'd like to leave this case out for that reason
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
