sungwy commented on code in PR #3: URL: https://github.com/apache/iceberg-verification/pull/3#discussion_r4084508833
########## table-spec/schema/README.md: ########## @@ -0,0 +1,141 @@ +<!-- + ~ Licensed to the Apache Software Foundation (ASF) under one + ~ or more contributor license agreements. See the NOTICE file + ~ distributed with this work for additional information + ~ regarding copyright ownership. The ASF licenses this file + ~ to you under the Apache License, Version 2.0 (the + ~ "License"); you may not use this file except in compliance + ~ with the License. You may obtain a copy of the License at + ~ + ~ http://www.apache.org/licenses/LICENSE-2.0 + ~ + ~ Unless required by applicable law or agreed to in writing, + ~ software distributed under the License is distributed on an + ~ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + ~ KIND, either express or implied. See the License for the + ~ specific language governing permissions and limitations + ~ under the License. + --> + +# Schema decoding + +Reading a schema JSON should produce the same schema in every implementation. +The assertions in this surface are intentionally scoped narrowly to catch +serialization issues of type strings (like decimal(P, S)), and allowed fields +within the Iceberg schema and its struct fields. + +## Assertion + +``` +project(parse(input)) == decoded +``` + +Bytes are not compared. The spec fixes no key order in a schema JSON, and does +not say whether an absent optional field is written out, so two byte-different +schema JSONs can be the same schema. `decoded` is the comparable form. + +## Scope + +This surface reads the schema JSON object and nothing around it. Writing a schema +back out is a later phase, per `CONTRIBUTING.md`. Whether a type is legal at a given Review Comment: we have `CONTRIBUTING.md` now: https://github.com/apache/iceberg-verification/blob/main/CONTRIBUTING.md -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
