sungwy commented on code in PR #3:
URL:
https://github.com/apache/iceberg-verification/pull/3#discussion_r4086950043
##########
table-spec/schema/geography/cases.json:
##########
@@ -0,0 +1,64 @@
+{
+ "cases": [
+ {
+ "id": "geography-defaults",
+ "valid": true,
+ "input": {
+ "type": "struct",
+ "schema-id": 0,
+ "fields": [
+ {
+ "id": 1,
+ "name": "id",
+ "required": true,
+ "type": "long"
+ },
+ {
+ "id": 2,
+ "name": "geog",
+ "required": false,
+ "type": "geography"
+ }
+ ]
+ },
+ "decoded": {
+ "schema-id": 0,
+ "identifier-field-ids": [],
+ "fields": [
+ { "id": 1, "name": "id", "parent": null, "required": true, "type":
"long", "doc": null },
+ { "id": 2, "name": "geog", "parent": null, "required": false,
"type": { "type": "geography", "crs": "OGC:CRS84", "algorithm": "spherical" },
"doc": null }
+ ]
+ }
+ },
+ {
+ "id": "geography-explicit-algorithm",
+ "valid": true,
+ "input": {
+ "type": "struct",
+ "schema-id": 0,
+ "fields": [
+ {
+ "id": 1,
+ "name": "id",
+ "required": true,
+ "type": "long"
+ },
+ {
+ "id": 2,
+ "name": "geog",
+ "required": false,
+ "type": "geography(srid:4326, vincenty)"
Review Comment:
Agreed this is a gap, but as noted above, I think we'll cover these cases in
#9
##########
table-spec/schema/timestamp-ns/cases.json:
##########
@@ -0,0 +1,41 @@
+{
+ "cases": [
+ {
+ "id": "timestamp-ns-both-zones",
+ "valid": true,
+ "input": {
+ "type": "struct",
+ "schema-id": 0,
+ "fields": [
+ {
+ "id": 1,
+ "name": "id",
+ "required": true,
+ "type": "long"
+ },
+ {
+ "id": 2,
+ "name": "event_ts",
+ "required": false,
+ "type": "timestamp_ns"
Review Comment:
Agreed this is a gap, but as noted above, I think we'll cover these cases in
#9
##########
table-spec/schema/unknown/cases.json:
##########
@@ -0,0 +1,34 @@
+{
+ "cases": [
+ {
+ "id": "unknown-optional",
+ "valid": true,
+ "input": {
+ "type": "struct",
+ "schema-id": 0,
+ "fields": [
+ {
+ "id": 1,
+ "name": "id",
+ "required": true,
+ "type": "long"
+ },
+ {
+ "id": 2,
+ "name": "future",
+ "required": false,
Review Comment:
Adding this
##########
table-spec/schema/variant/cases.json:
##########
@@ -0,0 +1,75 @@
+{
+ "cases": [
+ {
+ "id": "variant-top-level",
+ "valid": true,
+ "input": {
+ "type": "struct",
+ "schema-id": 0,
+ "fields": [
+ {
+ "id": 1,
+ "name": "id",
+ "required": true,
+ "type": "long"
+ },
+ {
+ "id": 2,
+ "name": "payload",
+ "required": false,
+ "type": "variant"
+ }
+ ]
+ },
+ "decoded": {
+ "schema-id": 0,
+ "identifier-field-ids": [],
+ "fields": [
+ { "id": 1, "name": "id", "parent": null, "required": true, "type":
"long", "doc": null },
+ { "id": 2, "name": "payload", "parent": null, "required": false,
"type": "variant", "doc": null }
+ ]
+ }
+ },
+ {
+ "id": "variant-in-struct",
+ "valid": true,
+ "input": {
+ "type": "struct",
+ "schema-id": 0,
+ "fields": [
+ {
+ "id": 1,
+ "name": "id",
+ "required": true,
+ "type": "long"
+ },
+ {
+ "id": 2,
+ "name": "event",
+ "required": false,
+ "type": {
+ "type": "struct",
+ "fields": [
+ {
+ "id": 3,
+ "name": "body",
+ "required": false,
+ "type": "variant"
Review Comment:
Agreed this is a gap, but as noted above, I think we'll cover these cases in
#9
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
