danielcweeks commented on code in PR #17709:
URL: https://github.com/apache/iceberg/pull/17709#discussion_r3808822129
##########
core/src/main/java/org/apache/iceberg/rest/RESTTableScan.java:
##########
@@ -228,7 +234,13 @@ private CloseableIterable<FileScanTask>
planTableScan(PlanTableScanRequest planT
private FileIO scanFileIO(List<Credential> storageCredentials) {
ImmutableMap.Builder<String, String> builder =
- ImmutableMap.<String, String>builder().putAll(catalogProperties);
+ ImmutableMap.<String, String>builder()
Review Comment:
I would also point out that the reason we build a custom IO for scan/plan is
due to the need for specific storage credentials (that's the input to this
function). However, with remote signing, that's not necessary since the
existing FileIO is properly built. The only additional information is the plan
ID. I'm ok rebuilding, but that original properties were the ones used to
build the original file io.
I don't think this is a semantic behavior change because there was never a
remote signing path and it's fundamentally different from the vended
credentials path.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
