adutra commented on code in PR #17709:
URL: https://github.com/apache/iceberg/pull/17709#discussion_r3806328548
##########
core/src/main/java/org/apache/iceberg/rest/RESTTableScan.java:
##########
@@ -228,7 +234,13 @@ private CloseableIterable<FileScanTask>
planTableScan(PlanTableScanRequest planT
private FileIO scanFileIO(List<Credential> storageCredentials) {
ImmutableMap.Builder<String, String> builder =
- ImmutableMap.<String, String>builder().putAll(catalogProperties);
+ ImmutableMap.<String, String>builder()
Review Comment:
I asked myself the same question. We could even get rid of the
`catalogProperties` field.
But that would be a semantic change: `operations.io().properties()` contains
3 layers of properties: catalog properties + table properties (from the
load-table-result config) + remote signing properties (set by the catalog).
However, the current code (inadvertently?) constructs the scan FileIO using
just the catalog properties, and nothing else.
So, `operations.io().properties()` indeed contains the remote signing
properties that we want, but it also contains the table properties.
IOW, your suggestion would make table properties available to the scan
FileIO, while today they aren't.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
