dramaticlly commented on PR #17709: URL: https://github.com/apache/iceberg/pull/17709#issuecomment-5333578232
> > @adutra This doesn't look like it needs to be stacked on the other PR. Can you please split them up? > > Hmm in this case we'd need @dramaticlly to change their PR #17627. They'd need to revert the changes to `S3V4RestSignerClient`. > > Are you OK with that @dramaticlly ? > > In this case we could split as follows: > > * [AWS: Remove deprecated S3 signer classes and properties #17627](https://github.com/apache/iceberg/pull/17627) removes orphaned classes _only_ > * [Core, REST, AWS: Implement RemoteSigningConfig #17709](https://github.com/apache/iceberg/pull/17709) (this PR) updates `S3V4RestSignerClient` > > UPDATE: I already reverted the removal of orphaned classes in this PR. Thanks @adutra for the coordination of the PR. I think it make sense for my #17627 to only focus on removing of deprecated class and leave `S3V4RestSignerClient` and its unit test unchanged. Updated and please take another look. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
