danielcweeks commented on code in PR #17709:
URL: https://github.com/apache/iceberg/pull/17709#discussion_r3808782673
##########
core/src/main/java/org/apache/iceberg/rest/RESTTableScan.java:
##########
@@ -85,6 +87,7 @@ class RESTTableScan extends DataTableScan {
private final ParserContext parserContext;
private final Map<String, String> catalogProperties;
private final Object hadoopConf;
+ private final RemoteSigningConfig remoteSigningConfig;
Review Comment:
This is a bit messy because we're both deserializing and reserializing the
config. The original RESTTable file io is already properly configured for
signing. Unlike the vended credentials path, we should be able to just get the
configuration from the original file io (we're effectively passing through two
different paths: the ops->file-io and the signing config). Just grab the
properties from the already configured fileio if they're set and we can avoid
this additional plumbing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
