rahulsmahadev commented on code in PR #16762:
URL: https://github.com/apache/iceberg/pull/16762#discussion_r3416969805
##########
core/src/main/java/org/apache/iceberg/ManifestFiles.java:
##########
@@ -562,6 +562,15 @@ private static ManifestFile copyManifestInternal(
return writer.toManifestFile();
}
+ static InputFile newInputFile(FileIO io, ManifestListFile manifestList) {
Review Comment:
Done in 001a9f7. Moved `newInputFile(FileIO, ManifestListFile)` to
`ManifestLists` and updated the call site in `BaseSnapshot`. The `ContentCache`
stays in `ManifestFiles` since manifest files and manifest lists are both
cached through it; `ManifestLists` just reaches back through the
package-private `ManifestFiles.cachingEnabled` / `ManifestFiles.contentCache`
helpers. PTAL.
##########
core/src/main/java/org/apache/iceberg/ManifestFiles.java:
##########
@@ -562,6 +562,15 @@ private static ManifestFile copyManifestInternal(
return writer.toManifestFile();
}
+ static InputFile newInputFile(FileIO io, ManifestListFile manifestList) {
Review Comment:
Done in 001a9f7 — see [reply
above](https://github.com/apache/iceberg/pull/16762#discussion_r3409127893).
Right reading on the reason: kept the cache on `ManifestFiles` and just routed
`ManifestLists.newInputFile` through it via the existing package-private
helpers.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
