szehon-ho commented on code in PR #16762:
URL: https://github.com/apache/iceberg/pull/16762#discussion_r3409127893
##########
core/src/main/java/org/apache/iceberg/ManifestFiles.java:
##########
@@ -562,6 +562,15 @@ private static ManifestFile copyManifestInternal(
return writer.toManifestFile();
}
+ static InputFile newInputFile(FileIO io, ManifestListFile manifestList) {
Review Comment:
Hi @rahulsmahadev , I was thinking , it seems weird to have public
ManifestList method on ManifestFiles. Can we do this on ManifestLists.
```
static List<ManifestFile> read(FileIO io, ManifestListFile manifestList) {
return read(ManifestFiles.newInputFile(io, manifestList));
}
```
And then have basesnapshot:
```
this.allManifests =
ManifestLists.read(fileIO, new
BaseManifestListFile(manifestListLocation, keyId));
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
