singhpk234 commented on code in PR #16762:
URL: https://github.com/apache/iceberg/pull/16762#discussion_r3410103014
##########
core/src/main/java/org/apache/iceberg/ManifestFiles.java:
##########
@@ -562,6 +562,15 @@ private static ManifestFile copyManifestInternal(
return writer.toManifestFile();
}
+ static InputFile newInputFile(FileIO io, ManifestListFile manifestList) {
Review Comment:
+1 on putting this to the ManifestListFiles, i believe its done to use
manifest cache which is private static final in the ManifestFile
https://github.com/apache/iceberg/blob/ce4d7d8973cbe57306ef4927fbafa6ca53b5982c/core/src/main/java/org/apache/iceberg/ManifestFiles.java#L73
Also reusing the cache which strictly just caches ManifestFiles to cache
ManifestLists seems a bit odd to me as they are not same.
if its absolutely required, we might wanna introduce a new cache for
manifestLists or unify the cache saying iceberg metadata cache ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
