rahulsmahadev commented on code in PR #16762:
URL: https://github.com/apache/iceberg/pull/16762#discussion_r3390511880
##########
core/src/main/java/org/apache/iceberg/ManifestFiles.java:
##########
@@ -562,6 +562,15 @@ private static ManifestFile copyManifestInternal(
return writer.toManifestFile();
}
+ static InputFile newInputFile(FileIO io, ManifestListFile manifestList) {
+ InputFile input = io.newInputFile(manifestList);
+ if (cachingEnabled(io)) {
Review Comment:
I wonder if its good practice to add a new knob here or use the existing one
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
