amogh-jahagirdar commented on code in PR #16688:
URL: https://github.com/apache/iceberg/pull/16688#discussion_r3376045957
##########
core/src/main/java/org/apache/iceberg/TrackedFile.java:
##########
@@ -49,6 +49,9 @@ interface TrackedFile {
Types.NestedField FILE_SIZE_IN_BYTES =
Types.NestedField.required(
104, "file_size_in_bytes", Types.LongType.get(), "Total file size in
bytes");
+ Types.NestedField WRITER_FORMAT_VERSION =
+ Types.NestedField.required(
Review Comment:
>We use null/optional for other new fields introduced in v2 and v3 (like
sequence number etc.). null or 0 carry the same semantic meaning.
We could do this but I think it complicates the spec a bit more; we'd have
to have a read side interpretation rule to say "Hey if it's null, then it's
pre-v4". Compared to it just being clear from being explcitly written.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
