gaborkaszab commented on code in PR #16688:
URL: https://github.com/apache/iceberg/pull/16688#discussion_r3389437531
##########
core/src/main/java/org/apache/iceberg/TrackedFile.java:
##########
@@ -49,6 +49,9 @@ interface TrackedFile {
Types.NestedField FILE_SIZE_IN_BYTES =
Types.NestedField.required(
104, "file_size_in_bytes", Types.LongType.get(), "Total file size in
bytes");
+ Types.NestedField WRITER_FORMAT_VERSION =
+ Types.NestedField.required(
Review Comment:
Thanks for the feedback, @stevenzwu !
I personally am fine with points 1. and 3. , but forward-compatibility is no
doubt an issue. Thanks for pointing that out! I'll get back with a non-enum
implementation soon.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
