gaborkaszab commented on code in PR #16688:
URL: https://github.com/apache/iceberg/pull/16688#discussion_r3373060547
##########
core/src/main/java/org/apache/iceberg/TrackedFile.java:
##########
@@ -110,7 +113,8 @@ static Types.StructType schemaWithContentStats(
MANIFEST_INFO,
KEY_METADATA,
SPLIT_OFFSETS,
- EQUALITY_IDS);
+ EQUALITY_IDS,
+ WRITER_FORMAT_VERSION);
Review Comment:
You're right. I didn't want to mess with the current order, but since this
is still under development, we can place these new items flexibly. I think the
ordinals in `TrackedFileStruct.internalSet()` and
`TrackedFileStruct.getByPos()` should also reflect this positioning (otherwise
some test also fails) so I made this adjustment too.
In the test I introduced variables for the schema filed ordinals to be more
robust for any future changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
