stevenzwu commented on code in PR #16688:
URL: https://github.com/apache/iceberg/pull/16688#discussion_r3375062043
##########
core/src/main/java/org/apache/iceberg/TrackedFile.java:
##########
@@ -110,7 +113,8 @@ static Types.StructType schemaWithContentStats(
MANIFEST_INFO,
KEY_METADATA,
SPLIT_OFFSETS,
- EQUALITY_IDS);
+ EQUALITY_IDS,
+ WRITER_FORMAT_VERSION);
Review Comment:
yes, it is better to maintain the proper order. we can adjust the test code
accordingly.
> In the test I introduced variables for the schema filed ordinals to be
more robust for any future changes.
this is great
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
