nastra commented on code in PR #16501:
URL: https://github.com/apache/iceberg/pull/16501#discussion_r3286984348
##########
arrow/src/main/java/org/apache/iceberg/arrow/vectorized/VectorizedArrowReader.java:
##########
@@ -252,7 +252,16 @@ private static Types.NestedField getPhysicalType(
// Use FixedSizeBinaryVector for binary backed decimal
type = Types.FixedType.ofLength(primitive.getTypeLength());
}
- physicalType = Types.NestedField.from(logicalType).ofType(type).build();
Review Comment:
what about keeping the original call but nulling out the defaults?
```
.withInitialDefault(null)
.withWriteDefault(null)
```
I think that would be more explicit and show the intent
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
