amogh-jahagirdar commented on code in PR #16501:
URL: https://github.com/apache/iceberg/pull/16501#discussion_r3289220855
##########
spark/v4.1/spark/src/test/java/org/apache/iceberg/spark/data/vectorized/parquet/TestParquetVectorizedReads.java:
##########
@@ -460,6 +473,42 @@ public void testUuidReads() throws Exception {
assertRecordsMatch(schema, numRows, data, dataFile, false, BATCH_SIZE);
}
+ @Test
+ public void testDecimalWithDefaultValueNotDictionaryEncoded() throws
Exception {
+ // Regression test for vector allocation of a decimal column whose Iceberg
field carries a
+ // default value. The bug only surfaces when the column is not
dictionary-encoded, because
+ // VectorizedArrowReader#allocateDictEncodedVector bypasses the buggy code
path.
Review Comment:
I'd leave out this comment, for someone reading it fresh or without context
it's unclear what "the bug" refers to. The test name itself makes it clear
what's being tested
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
