amogh-jahagirdar commented on code in PR #16501:
URL: https://github.com/apache/iceberg/pull/16501#discussion_r3289207633
##########
arrow/src/test/java/org/apache/iceberg/arrow/vectorized/TestArrowReader.java:
##########
@@ -388,6 +388,99 @@ public void testTimestampMillisAreReadCorrectly() throws
Exception {
assertThat(totalRowsRead).as("Should read all
rows").isEqualTo(millisValues.size());
}
+ /**
+ * Regression test: a decimal column whose Iceberg field carries an
initialDefault/writeDefault
Review Comment:
@pvary @nastra That's reasonable, though if we're going to do it I think
we'd want a whole suite of default value tests in the arrow module. I don't
thiink adding to this existing TestArrowReader makes sense for default values.
At the moment, we just rely on test implementations in engine modules which
extend DataTestBase and override the `supportsDefaultValues` mixin but you're
right that since the arrow module exposes the default value constructs itself,
we should have tests in this module and not rely on engine tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
