rdblue commented on code in PR #16263:
URL: https://github.com/apache/iceberg/pull/16263#discussion_r3228824164
##########
core/src/main/java/org/apache/iceberg/MergingSnapshotProducer.java:
##########
@@ -1250,7 +1250,13 @@ protected ManifestWriter<DataFile>
newManifestWriter(PartitionSpec manifestSpec)
@Override
protected ManifestReader<DataFile> newManifestReader(ManifestFile
manifest) {
- return MergingSnapshotProducer.this.newManifestReader(manifest);
+ return newManifestReader(manifest, true);
Review Comment:
I'm fine with this default, but we should probably start requiring
`isCommitted` to be passed. Can we deprecate the old one and start using this
exclusively?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
