amogh-jahagirdar commented on code in PR #16263:
URL: https://github.com/apache/iceberg/pull/16263#discussion_r3229181311
##########
core/src/test/java/org/apache/iceberg/TestRowLineageAssignment.java:
##########
@@ -781,6 +781,33 @@ public void
testUpgradeAssignmentWithManifestCompaction(@TempDir File altLocatio
FILE_C.recordCount() + FILE_B.recordCount());
}
Review Comment:
Ok so I've added 2 tests to ManifestReader; 1 for testing the uncommitted
read path which preserves firstRowId (same path already being tested in the
TestRowLinegeAssignment) case, and 1 for testing the committed manifest read
path where we expect to null out the entry's first row ID. Since we're now
distinguishing between uncommitted and committed, we have a good abstraction
boundary to test.
The committed test is something that would detect if the behavior to
defensively null out entries changed (verified by commenting out the most
recent changes we made, and going back to what we had before).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
