amogh-jahagirdar commented on code in PR #16263:
URL: https://github.com/apache/iceberg/pull/16263#discussion_r3222619132
##########
core/src/main/java/org/apache/iceberg/MergingSnapshotProducer.java:
##########
@@ -1250,7 +1250,13 @@ protected ManifestWriter<DataFile>
newManifestWriter(PartitionSpec manifestSpec)
@Override
protected ManifestReader<DataFile> newManifestReader(ManifestFile
manifest) {
- return MergingSnapshotProducer.this.newManifestReader(manifest);
+ return newManifestReader(manifest, true);
Review Comment:
Preserves the existing behavior for newManifestReader. While the
"isCommitted" is only passed through for the Data file manifest merging case,
it's a bit more involved to just put it on that implementation rather than the
base class. I think this is the cleanest way (and besides this is all
private/package private classes).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
