amogh-jahagirdar commented on code in PR #16263:
URL: https://github.com/apache/iceberg/pull/16263#discussion_r3227948840
##########
core/src/test/java/org/apache/iceberg/TestRowLineageAssignment.java:
##########
@@ -781,6 +781,33 @@ public void
testUpgradeAssignmentWithManifestCompaction(@TempDir File altLocatio
FILE_C.recordCount() + FILE_B.recordCount());
}
Review Comment:
So there's a nuance to "change the behavior" which is why all the tests in
the previous commit passed. Even with the previous commit, we ended up
correctly setting row ID to null because the entries in older manifest wouldn't
have a first row ID, so the behavior was preserved for the main case we care
about for older manifests, and there's quite a few tests there for the upgrade
path.
The case we're talking about though is a case where we (somehow?) produce a
pre-v3 manifest with first row IDs and we should ignore those by defensively
setting those to null; in that specific case, there was a behavior change
because we'd just keep those row IDs. I'll see about adding a test but I'm not
sure if we really even expose the mechanisms to produce a V2 manifest with
first row IDs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
