Baunsgaard commented on code in PR #16237:
URL: https://github.com/apache/iceberg/pull/16237#discussion_r3216941834
##########
kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/channel/Coordinator.java:
##########
@@ -148,13 +148,17 @@ protected boolean receive(Envelope envelope) {
}
private void commit(boolean partialCommit) {
+ // Do not swallow commit failures: wrap with Coordinator context and
propagate so
+ // CoordinatorThread.run() terminates and the Kafka Connect task
transitions to FAILED
+ // instead of silently dropping data (e.g., CommitFailedException from
catalogs that
+ // detect concurrent updates). The taskId and commitId are embedded in the
wrapper
+ // message so that the single log emitted by CoordinatorThread retains the
context.
Review Comment:
nit: I think it is too much to leave this comment. It is a personal
preference, but I would remove it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
