yadavay-amzn commented on PR #16237: URL: https://github.com/apache/iceberg/pull/16237#issuecomment-4462034549
Thanks for the thorough review @laskoviymishka. Addressed all points: 1. **Rethrow original exception** -- no longer wrapping in `RuntimeException`. The original `CommitFailedException` (or whatever the commit throws) is logged at ERROR and rethrown directly, preserving the type for alerting. 2. **Partial-commit gating** -- rethrow is now gated on `!partialCommit`. Transient failures during partial commits are logged but not fatal, matching the previous retry behavior. Only full-commit failures terminate the coordinator. 3. **Updated test assertions** -- tests now expect the original exception types directly. Will update the PR description to accurately reflect the narrowed catch and the mechanism for task FAILED transition. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
