yadavay-amzn commented on PR #16237: URL: https://github.com/apache/iceberg/pull/16237#issuecomment-4469504269
@laskoviymishka You are right -- the `CleanableFailure` approach was too permissive. Reverted to the simpler and safer design: - **Full commit failure**: rethrow everything (kills coordinator -> task FAILED) - **Partial commit failure** (timed-out cleanup): WARN + swallow (retry next cycle) This matches your original direction. The `CleanableFailure` detour was me trying to work around a CI integration test failure that turned out to be transient -- the test passes 10/10 locally with this approach. PR description updated to match the code. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
