yadavay-amzn commented on code in PR #16237:
URL: https://github.com/apache/iceberg/pull/16237#discussion_r3211813885
##########
kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/channel/Coordinator.java:
##########
@@ -148,14 +148,18 @@ protected boolean receive(Envelope envelope) {
}
private void commit(boolean partialCommit) {
+ // Do not swallow commit failures: propagate them so CoordinatorThread
terminates
+ // and the Kafka Connect task transitions to FAILED instead of silently
dropping data
+ // (e.g., CommitFailedException from catalogs that detect concurrent
updates).
try {
doCommit(partialCommit);
- } catch (Exception e) {
- LOG.warn(
- "Coordinator {} failed to commit for commit {}, will try again next
cycle",
+ } catch (RuntimeException e) {
+ LOG.error(
+ "Coordinator {} failed to commit for commit {}; propagating failure
to terminate task",
taskId,
commitState.currentCommitId(),
e);
+ throw e;
Review Comment:
Done, updated in latest revision
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
