anoopj commented on code in PR #16092:
URL: https://github.com/apache/iceberg/pull/16092#discussion_r3148173722
##########
core/src/main/java/org/apache/iceberg/DeletionVectorStruct.java:
##########
@@ -124,4 +136,35 @@ public String toString() {
.add("cardinality", cardinality)
.toString();
}
+
+ static class Builder {
+ private String location = null;
Review Comment:
It is not a valid value. I was initially on the fence about adding
validations because the builders are only used for explicit construction
(mainly in tests, and not in the read/write path, which uses `set(pos, value)`
directly).
But adding validation in build() makes sense. I'll add checks that required
fields have been set, along with tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
