nastra commented on code in PR #16092:
URL: https://github.com/apache/iceberg/pull/16092#discussion_r3148121840
##########
core/src/test/java/org/apache/iceberg/TestDeletionVectorStruct.java:
##########
@@ -43,12 +44,13 @@ void testFieldAccess() {
@Test
void testCopy() {
- DeletionVectorStruct dv = new
DeletionVectorStruct(DeletionVector.schema());
-
- dv.set(0, "s3://bucket/data/dv.puffin");
- dv.set(1, 256L);
- dv.set(2, 128L);
- dv.set(3, 42L);
+ DeletionVectorStruct dv =
+ DeletionVectorStruct.builder()
Review Comment:
we should probably also have some tests where we're testing the builder's
validation code (once added)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
