nastra commented on code in PR #16092:
URL: https://github.com/apache/iceberg/pull/16092#discussion_r3153708477
##########
core/src/main/java/org/apache/iceberg/TrackingStruct.java:
##########
@@ -246,4 +266,68 @@ public String toString() {
.add("replaced_positions", replacedPositions == null ? "null" :
"(binary)")
.toString();
}
+
+ static class Builder {
+ private EntryStatus status = null;
+ private Long snapshotId = null;
+ private Long dataSequenceNumber = null;
+ private Long fileSequenceNumber = null;
+ private Long dvSnapshotId = null;
+ private Long firstRowId = null;
+ private byte[] deletedPositions = null;
+ private byte[] replacedPositions = null;
+
+ Builder status(EntryStatus entryStatus) {
+ this.status = entryStatus;
+ return this;
+ }
+
+ Builder snapshotId(Long id) {
+ this.snapshotId = id;
+ return this;
+ }
+
+ Builder dataSequenceNumber(Long sequenceNumber) {
+ this.dataSequenceNumber = sequenceNumber;
+ return this;
+ }
+
+ Builder fileSequenceNumber(Long sequenceNumber) {
+ this.fileSequenceNumber = sequenceNumber;
+ return this;
+ }
+
+ Builder dvSnapshotId(Long id) {
+ this.dvSnapshotId = id;
+ return this;
+ }
+
+ Builder firstRowId(Long rowId) {
+ this.firstRowId = rowId;
+ return this;
+ }
+
+ Builder deletedPositions(ByteBuffer positions) {
Review Comment:
should we have an overloaded method that takes byte[] instead of the
ByteBuffer? Seems like all calling sites wrap a byte[] into a ByteBuffer just
to extract it here again
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
