anoopj commented on code in PR #16092:
URL: https://github.com/apache/iceberg/pull/16092#discussion_r3134860480
##########
core/src/main/java/org/apache/iceberg/DeletionVectorStruct.java:
##########
@@ -41,6 +41,14 @@ class DeletionVectorStruct extends SupportsIndexProjection
implements DeletionVe
super(BASE_TYPE, type);
}
+ DeletionVectorStruct(String location, long offset, long sizeInBytes, long
cardinality) {
+ super(BASE_TYPE.fields().size());
+ this.location = location;
+ this.offset = offset;
+ this.sizeInBytes = sizeInBytes;
+ this.cardinality = cardinality;
+ }
Review Comment:
The existing convention for `StructLike` implementations is not to add
validations in constructors. (e.g. `BaseFile`). So prefer not adding it for
consistency.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
