lishuxu commented on code in PR #616: URL: https://github.com/apache/iceberg-cpp/pull/616#discussion_r3080345914
########## src/iceberg/catalog/rest/auth/auth_managers.cc: ########## @@ -98,4 +105,30 @@ Result<std::unique_ptr<AuthManager>> AuthManagers::Load( return it->second(name, properties); } +#ifdef ICEBERG_BUILD_SIGV4 +Result<std::unique_ptr<AuthManager>> MakeSigV4AuthManager( Review Comment: MakeSigV4AuthManager is implemented directly in auth_managers.cc, while all other factory functions (MakeNoopAuthManager, MakeBasicAuthManager, MakeOAuth2Manager) are defined in their own translation units and only declared in auth_manager_internal.h. Suggest moving the implementation to sigv4_auth_manager.cc for consistency. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
