plusplusjiajia commented on code in PR #616:
URL: https://github.com/apache/iceberg-cpp/pull/616#discussion_r3076967938
##########
.github/workflows/cpp-linter.yml:
##########
@@ -37,14 +37,26 @@ jobs:
uses: actions/checkout@v6
- name: Install dependencies
shell: bash
- run: sudo apt-get update && sudo apt-get install -y
libcurl4-openssl-dev
+ run: sudo apt-get update && sudo apt-get install -y
libcurl4-openssl-dev ninja-build
Review Comment:
Good question — I added a build step in this PR so the linter can see the
SigV4 code (needs compile_commands.json from a real build). I used cmake -G
Ninja for speed and to be consistent with the other CI workflows, and Ninja is
not preinstalled on ubuntu-24.04, hence the extra ninja-build package. Happy to
switch to Make if you'd prefer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
