plusplusjiajia commented on code in PR #616:
URL: https://github.com/apache/iceberg-cpp/pull/616#discussion_r3080180261
##########
src/iceberg/catalog/rest/auth/auth_session.h:
##########
@@ -50,7 +58,13 @@ class ICEBERG_REST_EXPORT AuthSession {
/// - NotAuthorized: Not authenticated (401)
/// - IOError: Network or connection errors when reaching auth server
/// - RestError: HTTP errors from authentication service
- virtual Status Authenticate(std::unordered_map<std::string, std::string>&
headers) = 0;
+ virtual Status Authenticate(std::unordered_map<std::string, std::string>&
headers,
Review Comment:
Thanks @lishuxu ! Agreed — aligning with Java's request-in/request-out
pattern is the right call. I'll address this in the current PR: introducing an
HTTPRequest type (encapsulating method, url, headers, body), changing the
signature to Result<HTTPRequest> Authenticate(const HTTPRequest& request). Will
push an update shortly — PTAL when it's ready.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
