lishuxu commented on code in PR #616:
URL: https://github.com/apache/iceberg-cpp/pull/616#discussion_r3080282543
##########
src/iceberg/catalog/rest/auth/auth_properties.h:
##########
@@ -59,6 +59,20 @@ class ICEBERG_REST_EXPORT AuthProperties : public
ConfigBase<AuthProperties> {
inline static const std::string kSigV4DelegateAuthType =
"rest.auth.sigv4.delegate-auth-type";
+ // ---- SigV4 AWS credential entries ----
Review Comment:
Nit: the // ---- SigV4 AWS credential entries ---- section header is
redundant given the // ---- SigV4 entries ---- block above already covers SigV4
config. Merge them into a single section.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
