swapna267 commented on code in PR #15780:
URL: https://github.com/apache/iceberg/pull/15780#discussion_r3025041371
##########
flink/v2.1/flink/src/main/java/org/apache/iceberg/flink/sink/dynamic/DynamicIcebergSink.java:
##########
@@ -358,31 +359,27 @@ private String operatorName(String suffix) {
}
private DynamicIcebergSink build() {
-
Preconditions.checkArgument(
generator != null, "Please use withGenerator() to convert the input
DataStream.");
Preconditions.checkNotNull(catalogLoader, "Catalog loader shouldn't be
null");
uidPrefix = Optional.ofNullable(uidPrefix).orElse("");
- Configuration flinkConfig =
- readableConfig instanceof Configuration
- ? (Configuration) readableConfig
- : Configuration.fromMap(readableConfig.toMap());
-
- return instantiateSink(writeOptions, flinkConfig);
+ return instantiateSink(writeOptions, getConfiguration());
}
@VisibleForTesting
DynamicIcebergSink instantiateSink(
Map<String, String> writeProperties, Configuration flinkWriteConf) {
+ FlinkDynamicSinkConf flinkDynamicSinkConf =
+ new FlinkDynamicSinkConf(writeOptions, flinkWriteConf);
Review Comment:
Based on usage `writeOptions` is what being sent. Wasn't intended. Corrected.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
