swapna267 commented on code in PR #15780:
URL: https://github.com/apache/iceberg/pull/15780#discussion_r3011509817
##########
flink/v2.1/flink/src/main/java/org/apache/iceberg/flink/sink/dynamic/DynamicRecordProcessor.java:
##########
@@ -111,7 +121,9 @@ public void processElement(T element, Context ctx,
Collector<DynamicRecordIntern
}
@Override
- public void collect(DynamicRecord data) {
+ public void collect(DynamicRecord inputData) {
+ DynamicRecordWithDefaults data = new DynamicRecordWithDefaults(inputData,
flinkWriteConf);
Review Comment:
I started that way, but felt that approach was little error prone for future
, as configs of DynamicRecord need to be overridden at different places for
different usages.
Write Parallelism / Distribution mode overrides need to be passed over to
HashKeyGenerator.
And overrides like branch/upsertMode should be passed to
DynamicRecordInternal.
So the approach would look like,
1. Build HashKeyGenerator with defaults for Write Parallelism / Distribution
mode .
2. Update all DynamicRecordInternal construction paths for defaults for
Branch.
Or another option could be to incorporate this into DynamicRecord itself by
having `setConfig(FlinkWriteConf flinkWriteConf)`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
